Add full floating point support with divFloat function #19
+150
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
paul/divf
branch
from
6a2e385
to
03779b7
Compare
samholmes
requested changes
Feb 27, 2024
| @@ -323,10 +335,11 @@ function cropHex(x: string): string { | |||
| function floatShifts( | |||
| xStart: string | number, | |||
| yStart: string | number, | |||
| moreShift?: number | |||
| doFloat: boolean = false | |||
There was a problem hiding this comment.
Can we make this a separate commit with a description of this internal function's signature?
There was a problem hiding this comment.
Hmm. Check out the comment and see if that's enough clarity
Comment on lines
+74
to
+82
| export function divf(x1: string, y1: string): string { | ||
| return div(x1, y1, true) | ||
| } |
There was a problem hiding this comment.
What happens when the decimal is repetitive?
There was a problem hiding this comment.
what do you mean by repetitive?
There was a problem hiding this comment.
What happens if x1 = '1' and y1 = '3'
samholmes
reviewed
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none